Skip to content

Comments

[PW_SID:1054087] riscv: fix minor typos and style issues in XIP code#1476

Closed
linux-riscv-bot wants to merge 3 commits intoworkflow__riscv__fixesfrom
pw1054087
Closed

[PW_SID:1054087] riscv: fix minor typos and style issues in XIP code#1476
linux-riscv-bot wants to merge 3 commits intoworkflow__riscv__fixesfrom
pw1054087

Conversation

@linux-riscv-bot
Copy link

@linux-riscv-bot linux-riscv-bot commented Feb 14, 2026

PR for series 1054087 applied to workflow__riscv__fixes

Name: riscv: fix minor typos and style issues in XIP code
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1054087
Version: 1

Linux RISC-V bot and others added 3 commits January 29, 2026 08:42
Adding CI files
42f6459
riscv: xip_fixup.h: fix comment typo and whitespace issue
5a8d586 
Fix two minor issues in XIP_FIXUP_OFFSET macro:

- The comment describes the fixup formula as
  "reg += CONFIG_PHYS_RAM_BASE - _start", but the actual assembly
  code subtracts _sdata, not _start. Fix the comment to match.

- Replace spaces with a tab for the "add" instruction to keep
  consistent indentation with surrounding lines.

Reviewed-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
Signed-off-by: Kunwu Chan <kunwu.chan@linux.dev>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
riscv: head.S: fix typo and wrong #endif comment
71ffd1c 
- Fix spelling: "intruction" -> "instruction".

- Fix #endif comment: the matching #ifdef is CONFIG_XIP_KERNEL,
  not CONFIG_XIP.

Reviewed-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
Signed-off-by: Kunwu Chan <kunwu.chan@linux.dev>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 117.38 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1249.48 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1719.35 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.16 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 80.60 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
kdoc
Desc: Detects for kdoc errors
Duration: 0.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 1: "[RESEND,1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 2.54 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 115.45 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1232.58 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1692.76 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.91 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.39 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 81.08 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
kdoc
Desc: Detects for kdoc errors
Duration: 0.94 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 14, 2026

Patch 2: "[RESEND,2/2] riscv: head.S: fix typo and wrong #endif comment"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1054087 branch February 22, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@linux-riscv-bot